feat(applepay): calculate tax amount dynamically while changing shipping address in apple pay sdk #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImSagnik007
requested review from
seekshiva,
PritishBudhiraja and
ArushKapoorJuspay
as code owners
|
Review changes with SemanticDiff. |
ArushKapoorJuspay
previously approved these changes
Sep 12, 2024
…ing address in apple pay sdk Calculate tax amount and shipping cost dynamically while changing shipping address in apple pay sdk and update the new amount.
ImSagnik007
force-pushed
the
tax_calculation_support_apple_pay
branch
from
9822330 to
f9e27c1
Compare
seekshiva
previously approved these changes
Sep 13, 2024
PritishBudhiraja
added
the
Ready for Review
refactor
ImSagnik007
force-pushed
the
tax_calculation_support_apple_pay
branch
from
f2eb3d1 to
421ba6b
Compare
PritishBudhiraja
approved these changes
Sep 13, 2024
github-actions
bot
added
Closed
akash-c-k
pushed a commit
that referenced
this pull request
Sep 13, 2024
# [0.86.0](v0.85.0...v0.86.0) (2024-09-13) ### Features * **applepay:** calculate tax amount dynamically while changing shipping address in apple pay sdk ([#610](#610)) ([0804823](0804823))
Sanskar2001
reviewed
Sep 13, 2024
| @@ -83,6 +83,7 @@ type eventName = | |||
| | DELETE_SAVED_PAYMENT_METHOD | |||
| | DELETE_PAYMENT_METHODS_CALL_INIT | |||
| | DELETE_PAYMENT_METHODS_CALL | |||
| | EXTERNAL_TAX_CALCULATION | |||
There was a problem hiding this comment.
| EXTERNAL_TAX_CALCULATION_CALL
| EXTERNAL_TAX_CALCULATION_CALL_INIT
| @@ -166,6 +167,7 @@ let eventNameToStrMapper = eventName => { | |||
| | DELETE_SAVED_PAYMENT_METHOD => "DELETE_SAVED_PAYMENT_METHOD" | |||
| | DELETE_PAYMENT_METHODS_CALL_INIT => "DELETE_PAYMENT_METHODS_CALL_INIT" | |||
| | DELETE_PAYMENT_METHODS_CALL => "DELETE_PAYMENT_METHODS_CALL" | |||
| | EXTERNAL_TAX_CALCULATION => "EXTERNAL_TAX_CALCULATION" | |||
There was a problem hiding this comment.
|EXTERNAL_TAX_CALCULATION_CALL=>"EXTERNAL_TAX_CALCULATION_CALL"
|EXTERNAL_TAX_CALCULATION_CALL_INIT=>"EXTERNAL_TAX_CALCULATION_CALL_INIT"
| ~optLogger=Some(logger), | ||
| ~url=uri, | ||
| ~apiLogType=Request, | ||
| ~eventName=EXTERNAL_TAX_CALCULATION, |
There was a problem hiding this comment.
~eventName=EXTERNAL_TAX_CALCULATION_CALL_INIT
| ~data, | ||
| ~statusCode, | ||
| ~apiLogType=Err, | ||
| ~eventName=EXTERNAL_TAX_CALCULATION, |
There was a problem hiding this comment.
~eventName=EXTERNAL_TAX_CALCULATION_CALL
| ~url=uri, | ||
| ~statusCode, | ||
| ~apiLogType=Response, | ||
| ~eventName=EXTERNAL_TAX_CALCULATION, |
There was a problem hiding this comment.
~eventName=EXTERNAL_TAX_CALCULATION_CALL
| ~optLogger=Some(logger), | ||
| ~url=uri, | ||
| ~apiLogType=NoResponse, | ||
| ~eventName=EXTERNAL_TAX_CALCULATION, |
There was a problem hiding this comment.
~eventName=EXTERNAL_TAX_CALCULATION_CALL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculate tax amount and shipping cost dynamically while changing shipping address in apple pay sdk and update the new amount.
Listening to the
onShippingContactSelectedlistener while there is a change in shipping address, abd based on the new shipping address calling taxjar api to get new amount and updating that in sdk.Type of Change
Description
How did you test it?
Checklist
npm run re:build